Closed ChrisOboe closed 1 month ago
Thanks for reporting this issue.
Yeah. Album is not currently implemented (I have no use of it) but it should be pretty easy to add it. I'll definitely try to find time to implement it soon. Otherwise if you're willing to do it yourself feel free to send a PR.
As for the title missing, I'm interested in digging a bit further to understand what is going on. Could you run mprisqueeze
with debug logging on?
$ RUST_LOG=debug mprisqueeze -H somehost -P 9000
It'll output the requests sent to the server along its responses. For example here is what I have:
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Sending: LmsRequest { method: "slim.request", params: ("shinystuff", ["mode", "?"]) }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Received: LmsResponse { method: "slim.request", params: ("shinystuff", ["mode", "?"]), result: Object {"_mode": String("pause")} }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Converted as: Pause
[2024-09-22T19:07:08Z DEBUG mprisqueeze::mpris] MprisPlayer::loop_status
[2024-09-22T19:07:08Z DEBUG mprisqueeze::mpris] MprisPlayer::shuffle
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Sending: LmsRequest { method: "slim.request", params: ("shinystuff", ["playlist", "shuffle", "?"]) }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Received: LmsResponse { method: "slim.request", params: ("shinystuff", ["playlist", "shuffle", "?"]), result: Object {"_shuffle": Number(0)} }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Converted as: Off
[2024-09-22T19:07:08Z DEBUG mprisqueeze::mpris] MprisPlayer::metadata
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Sending: LmsRequest { method: "slim.request", params: ("shinystuff", ["playlist", "tracks", "?"]) }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Received: LmsResponse { method: "slim.request", params: ("shinystuff", ["playlist", "tracks", "?"]), result: Object {"_tracks": Number(9)} }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Converted as: 9
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Sending: LmsRequest { method: "slim.request", params: ("shinystuff", ["current_title", "?"]) }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Received: LmsResponse { method: "slim.request", params: ("shinystuff", ["current_title", "?"]), result: Object {"_current_title": String("The Beginning and the End")} }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Converted as: Some("The Beginning and the End")
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Sending: LmsRequest { method: "slim.request", params: ("shinystuff", ["artist", "?"]) }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Received: LmsResponse { method: "slim.request", params: ("shinystuff", ["artist", "?"]), result: Object {"_artist": String("Isis")} }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Converted as: Some("Isis")
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Sending: LmsRequest { method: "slim.request", params: ("shinystuff", ["playlist", "index", "?"]) }
[2024-09-22T19:07:08Z DEBUG mprisqueeze::lms] Received: LmsResponse { method: "slim.request", params: ("shinystuff", ["playlist", "index", "?"]), result: Object {"_index": String("0")} }
Also which version of LMS are you running?
I've been running the version from this branch this week. It contains support for the album, and I've used another call to LMS for the title.
$ playerctl metadata
shinystuff mpris:trackid '/org/mpris/MediaPlayer2/shinystuff/track/10'
shinystuff xesam:album Perfect From Now On
shinystuff xesam:artist Built to Spill
shinystuff xesam:title Untrustable / Part 2 (About Someone Else)
Let me know if it fixes your issue. I'll merge it sometime next week. I want to keep using it for a few days, to make sure it runs fine.
Sorry for the late reply and thank you for your fast fix. My lms servier is lyron 8.5.2 With the album-title-fix branch it works as expected.
Thx for your feedback.
Looking at the debug log, we can see that the current_title
request returns an empty string in your case. I can't remember why I chose current_title
over title
when implementing this :thinking:
Anyway, I've merged this branch and created a new release.
Closing as it is now fixed in v0.1.7
The Metadata property has an empty title and no album at all. The artist is there.
Here a screenshot from D-Spy
Here a screenshot from a different MPRIS provider (kdeconnect, grabbing the data from squeezer on my phone) as comparison