search

jech / galene

The Galène videoconference server
https://galene.org
MIT License
944 stars 130 forks source link

Menu disappears behind broadcasted files #139

Closed ericgaspar closed 2 years ago

ericgaspar commented 2 years ago

Depending on where you click, the contextual menu appears in different places and behind the show chat icon and the broadcasted file.

Capture d’écran 2022-03-26 à 14 08 06

Capture d’écran 2022-03-26 à 14 07 08

jech commented 2 years ago

Yep. Unfortunately, the galene.css file is a mess — it's abusing both z-index and !important to do all sorts of weird things, which means that any addition requires changes all over the place. @takdj, any ideas?

ericgaspar commented 2 years ago

z-index: 1010; is missing in static/external/contextual/contextual.css for .contextualMenu

(chat button being z-index: 1002;)

Why 1010? ¯\_(ツ)_/¯ (I am not up-to-date in css...)

jech commented 2 years ago

I don't want to be modifying the files in external, it will make upgrading a pain. We must fix Galene's CSS so it's compatible with external libraries.

jech commented 2 years ago

Fixed in 96f39ca. I'm an idiot.

(However, somebody should still go through galene.css and fix the mess. The abuse of z-index is abhorrent.)