search

jech / galene

The Galène videoconference server
https://galene.org
MIT License
900 stars 119 forks source link

galene 0.6 allows users to connect before /unlock #147

Closed stroeder closed 1 year ago

stroeder commented 1 year ago

I'm always creating groups with "autolock": true. Until galene 0.5.5 a session was locked until the session operator input /unlock which is the desired behaviour.

Since galene 0.6 users (without password) can already connect and see the session video before /unlock.

jech commented 1 year ago

The behaviour did not change, but arguably it is not right.

With autolock, a group gets automatically locked when the last client leaves the group. However, it does not start in a locked state: if you want the group to be locked before the first user joins, you need to also specify locked in the group description. The feature is intended to allow people to freely join a meeting, but to prevent them from coming back to the meeting after it is ended, and was requested by somebody who feared that people would see confidential documents in the chat by coming back after a meeting.

But perhaps it's not the right behaviour? Perhaps "autolock" should imply that the group is initially locked?

jech commented 1 year ago

After thinking it over, you're right. Fixed in https://github.com/jech/galene/commit/62517844a5193bcaf34c156c500fd70ac5d72a33.