jech / galene

The Galène videoconference server
https://galene.org
MIT License
899 stars 119 forks source link

WHIP: panic on /whip #159

Closed erdnaxe closed 11 months ago

erdnaxe commented 1 year ago

While testing whip branch, I got a panic at https://github.com/jech/galene/commit/7c2bc04359466ed81098ce77477fb47d4b426557#diff-b816908f2b221093098f09c7d651135fb78dec9ceacff38d82dccc922e528005R275.

I believe this happens when a POST request is sent to /whip without a trailing /. Maybe this condition should check p length before p[:6] != "/whip/" ?

jech commented 1 year ago

Right, thanks. I'll keep that in mind when I update the whip branch.

jech commented 11 months ago

The whip branch is obsolete, please use the branch whip2 instead.