jech / galene

The Galène videoconference server
https://galene.org
MIT License
977 stars 133 forks source link

autolock #230

Open jjsarton opened 2 weeks ago

jjsarton commented 2 weeks ago

According to the README file:

- `autolock`: if true, the group will start locked and become locked
   whenever there are no clients with operator privileges;
 - `autokick`: if true, all clients will be kicked out whenever there are
   no clients with operator privileges; this is not recommended, prefer
   the `autolock` option instead;

Actually autolock has the same behaviour as bug #229 (autokick) I kann not login as op if autolock is set.

Version Galene with fix for bug #229

jech commented 2 weeks ago

Actually autolock has the same behaviour as bug #229 (autokick) I kann not login as op if autolock is set.

I cannot reproduce this. Could you please give intstructions for reproducing?

(To be fair, I'm quite tempted to remove both autolock and autokick, since I don't think anyone is using this functionality now that we have token management. Please yell if you disagree.)

jjsarton commented 2 weeks ago

I think, that "autolock" may be removed, "autokick" may be sufficient for me. If "autokick" is set, user may not connect to the room and are kicked out if no more "op" are present. The config is as follow:

{
    "users": { "op": {"password": "opsecret", "permissions": "op"}},
    "wildcard-user":{"password": {"type": "wildcard"}, "permissions": "present"},
    "codecs": ["vp8", "opus"],
    "public": true,
     "autokick": true
}

In order to test this I launch a web browser and try to login as "op", I get a message telling that the room is locked.

jech commented 2 weeks ago

Your group definition says "autokick", not "autolock". Is that a typo?

jjsarton commented 2 weeks ago

Your group definition says "autokick", not "autolock". Is that a typo?

Sorry this what a typo!

jech commented 2 weeks ago

I've copied your file, replaced "autokick" with "autolock", and logged in successfully as "op". Perhaps you made a typo somewhere?

jjsarton commented 2 weeks ago

I will check this.

jjsarton commented 2 weeks ago

I can login as OP, this work. after this opening as normal user, I get Room locked. This may be OK only OP member can use this room.

jech commented 2 weeks ago

Yes, that's the expected behaviour. The group gets automatically locked when the last op leaves, but an op needs to manually unlock it.

Close bug?

12 Nov 2024 16:10:08 Jean-Jacques Sarton @.***>:

I can login as OP, this work. after this opening as normal user, I get Room locked. This may be OK only OP member can use this room.

— Reply to this email directly, view it on GitHub[https://github.com/jech/galene/issues/230#issuecomment-2470791879], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AACG4JN4K5PUXNKW4HSJS4L2AIK43AVCNFSM6AAAAABRSL7BYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZQG44TCOBXHE]. You are receiving this because you commented. [Tracking image][https://github.com/notifications/beacon/AACG4JLKFMDNGTSCGB4VCML2AIK43A5CNFSM6AAAAABRSL7BYWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUTIVFMO.gif]