search

jech / galene

The Galène videoconference server
https://galene.org
MIT License
944 stars 130 forks source link

Set of small fixes for static files #68

Closed erdnaxe closed 3 years ago

erdnaxe commented 3 years ago

If you prefer to have these fixes separated in distinct pull requests, I can split this PR.

About the commit adding the missing <meta charset="utf-8">, it is defined inside 404.html and index.html, so for the sake of consistency I added it to galene.html. This enables someone to directly serve the static with a webserver that does not announce an UTF-8 charset.

Some other thoughts that requires discussion (maybe for another PR?):

I am also planing later to submit a PR to change the height: calc(100vh - 50px); in mainpage.css to a flexbox, because the current footer is causing overflow on my Firefox (demo of the change: https://neree.crans.org/).

Best regards,

jech commented 3 years ago

Thanks. I'll apply all of your changes except the last one — /me is deliberately undocumented, think of it as an easter egg for people who read the code. (To tell the truth, it used to be documented, and it confused people — I was receiving a lot of mails asking me what it does.)

Should we put all scripts in static/scripts/ and all stylesheets in static/css/?

No. static/scripts and static/css are for third-party files.

Should we split galene.js into galene-layout.js (manages the layout of the page) and galene.js for all the rest?

It's a good idea if it can be done cleanly. I cannot at this point decide whether I'd accept a patch that does that.

Can we remove font-awesome from index.html?

No idea. @takdj ?

If I contribute some SVG, will Galène still require font-awesome dependency?

No idea. @takdj ?

takdj commented 3 years ago

Can we remove font-awesome from index.html?

Yes, it's not used there.

If I contribute some SVG, will Galène still require font-awesome dependency?

font-awesome icons can be replaced by SVG but galene.css currently need it as dependency for some few styles.