search

jech / polipo

The Polipo caching HTTP proxy
http://www.pps.jussieu.fr/~jch/software/polipo/
MIT License
1.81k stars 354 forks source link

TCP Fast Open #62

Open pysiak opened 9 years ago

pysiak commented 9 years ago

Would you consider adding TCP Fast Open support? There's a small and simple example patch here: https://github.com/dtaht/ceropackages-3.10/blob/cf6fd6a01fdfbddb468f2a3ea27b6450955b674a/net/polipo/patches/001-server_tfo.patch

jech commented 9 years ago

Can you provide tcpdump traces that show that this patch actually does something?

ketkulka commented 8 years ago

I did this patch for cerowrt (bufferbloat.net) originally. At the time, the kernel was not fully baked to include TCP Fast Open support. I assume it is now. If adding TCP Fast Open is welcome in polipo, I can try provide the complete patch set along with any supporting logs, pcaps.

jech commented 8 years ago

If adding TCP Fast Open is welcome in polipo, I can try provide the complete patch set along with any supporting logs, pcaps.

Please. Just a well-chosen pcap will be fine. Latency benchmarks welcome, of course, we all love benchmarks.

simontretter commented 8 years ago

@ketkulka Any progress on this?

lemenkov commented 8 years ago

@simontretter see this commit - ab52932c20638491f696e256020ad6a20aad7939. I'm afraid it's time to close this and any other issues as WONTFIX.

pysiak commented 8 years ago

Ketan, it seems we didn't make it with the FASTOPEN patch soon enough :-) I was really going to produce tcpdumps for it as it''s trivial... Anyway, thanks @jech for polipo. I've been chaining it with privoxy on my home router.