React 18 double-render in Strict Mode breaks component

jechav / tiny-slider-react

wrapper of tiny-slider plugin for react.

https://tiny-slider-react-tests.netlify.app/

47 stars 27 forks source link

React 18 double-render in Strict Mode breaks component #61

Open betaorbust opened 1 year ago

betaorbust commented 1 year ago

Description

In React 18, <StrictMode> was introduced, that effectively just re-renders everything twice to shake out memory leaks and unintended bugs. It looks like this causes tiny-slider-react to throw or not show up on the page. By triggering on and off Strict Mode I can pretty reliably cause an error.

Reproduction

Here is a full repro case. Adjusting the TRIGGER_BUG variable to true will enable Strict Mode and cause the issues I've been seeing.

zavsievich commented 1 year ago

Hi! Small update: the current version of the slider is 0.5.7 and the problem is still there: now the page doesn't crash, but the slider doesn't initialize. You can see it in your CodeSandbox if you updated the version.