jeckman / YouTube-Downloader

PHP script for downloading videos from youtube; also parsing youtube feed into RSS enclosures for podcatchers
GNU General Public License v2.0
895 stars 474 forks source link

createCurlOptions() must be of the type array #362

Closed dribgnikcom closed 5 years ago

dribgnikcom commented 5 years ago

Hello,

I am now receiving this error after the latest update:

[Mon Dec 10 10:58:21.404385 2018] [:error] [pid 24795] [client 192.168.2.16:1640] PHP Notice:  Undefined variable: options in /home/nanopi/www/YouTube-Downloader/src/Http/CurlClient.php on line 106, referer$
[Mon Dec 10 10:58:21.404643 2018] [:error] [pid 24795] [client 192.168.2.16:1640] PHP Catchable fatal error:  Argument 2 passed to YoutubeDownloader\\Http\\CurlClient::createCurlOptions() must be of the typ$

Thank you

rudrabd commented 5 years ago

i didn't faced this problem after update.

dribgnikcom commented 5 years ago

Here's some more:

[Mon Dec 10 11:51:59.350273 2018] [:error] [pid 1049] [client 192.168.2.16:2754] PHP Notice:  Undefined variable: options in /home/nanopi/www/YouTube-Downloader/src/Http/CurlClient.php on line 126, referer:
http://192.168.2.237:12323/YouTube-Downloader/
[Mon Dec 10 11:51:59.350545 2018] [:error] [pid 1049] [client 192.168.2.16:2754] PHP Catchable fatal error:  Argument 2 passed to YoutubeDownloader\\Http\\CurlClient::createCurlOptions() must be of the type
array, null given, called in /home/nanopi/www/YouTube-Downloader/src/Http/CurlClient.php on line 126 and defined in /home/nanopi/www/YouTube-Downloader/src/Http/CurlClient.php on line 145, referer: http://19
2.168.2.237:12323/YouTube-Downloader/

i didn't faced this problem after update.

Maybe it has to do with PHP5, as was pointed out in my previous bug.

rudrabd commented 5 years ago

i hope developer of script will see this issue and solve it.

dribgnikcom commented 5 years ago

Yes, I hope so. In the meantime I reverted back to 0.8 with the following command:

git remote update
git fetch origin
git checkout $(git describe --abbrev=0 --tags 0.8)

0.8 is working fine as before (except for the decipher function on some videos).

Art4 commented 5 years ago

Thanks @dribgnikcom This bug will be fixed in 0.10, and using 0.8 at the meantime is also fine.