jecrell / DoorsExpanded

Door expansion pack for RImWorld.
MIT License
11 stars 9 forks source link

Not working for me with v1.1.2647 #28

Open dohamann opened 4 years ago

dohamann commented 4 years ago

I know this minor update wasn't supposed to break anything, but my savegame that worked great an hour earlier had a major issue with DoorsExpanded on load. Essentially all wide doors were uninstalled and only one half of the door was portrayed, even when spawning a new one in god mode.

I have no experience modding RimWorld but I guess this stacktrace is directly related to the problem:

Root level exception in OnGUI(): System.NullReferenceException: Object reference not set to an instance of an object
  at Verse.GridsUtility.GetThingList (Verse.IntVec3 c, Verse.Map map) [0x00000] in <0de063f107214aa3839ba3ee388b65f4>:0 
  at DoorsExpanded.Building_DoorExpanded.get_BlockedOpenMomentary () [0x0001e] in <67cde003d2de4e17b90e3af2229697df>:0 
  at DoorsExpanded.Building_DoorExpanded.SpawnSetup (Verse.Map map, System.Boolean respawningAfterLoad) [0x0005b] in <67cde003d2de4e17b90e3af2229697df>:0 
  at (wrapper dynamic-method) Verse.GenSpawn.DMD<DMD<Spawn_Patch2>?788563712::Spawn_Patch2>(Verse.Thing,Verse.IntVec3,Verse.Map,Verse.Rot4,Verse.WipeMode,bool)
  at RimWorld.Designator_Build.DesignateSingleCell (Verse.IntVec3 c) [0x00092] in <0de063f107214aa3839ba3ee388b65f4>:0 
  at Verse.DesignatorManager.ProcessInputEvents () [0x00058] in <0de063f107214aa3839ba3ee388b65f4>:0 
  at RimWorld.MapInterface.HandleMapClicks () [0x0000f] in <0de063f107214aa3839ba3ee388b65f4>:0 
  at RimWorld.UIRoot_Play.UIRootOnGUI () [0x00089] in <0de063f107214aa3839ba3ee388b65f4>:0 
  at (wrapper dynamic-method) Verse.Root.DMD<DMD<OnGUI_Patch1>?366962176::OnGUI_Patch1>(Verse.Root)

Log: https://pastebin.com/i6jren1T

lbmaian commented 4 years ago

Thanks for the logs. I believe this is an incompatibility with the Minify Everything mod that's been reported before.

PH_DoorJail429461.invisDoors[0] is unexpectedly unspawned - removing is rather telling.

Can you upload a save file that has this issue, one where the error will happen (NOT after the error has happened)? That would be helpful for root cause analysis.

Thanks!

lbmaian commented 4 years ago

@dohamann Can you try this dev build? https://github.com/lbmaian/DoorsExpanded/archive/master.zip

A HugsLib log would also be helpful. Ensure HugsLib is installed. If you still see the issue or have any logged errors, just press Ctrl+F12, upload, and then copy&paste the resulting URL here. Thanks.

dohamann commented 4 years ago

Thank you for your efforts! I can't try it right now but I will get back to you within 24h.

dohamann commented 4 years ago

Sadly still the same issues.

https://gist.github.com/fae571547e2618eea2659cf311d15ff5

lbmaian commented 4 years ago

@dohamann Thanks for the logs. Can you upload your save file as well? If zipped up, it should fit within github's attach file limit.

dohamann commented 4 years ago

Sure: DoorsExpanded_Issue_28.zip

lbmaian commented 4 years ago

Hmm, I can't reproduce the problem with that save and the same mods. Might be that our mod options are different. Can you zip up your Config folder (sibling folder to Saves folder) and upload it here?

In case I still can't reproduce it, please try this debug build that has a lot more debug logging: https://github.com/lbmaian/DoorsExpanded/archive/debug.zip

lbmaian commented 4 years ago

@dohamann I've revamped some code again and added more logging. Can you please install the updated version at https://github.com/lbmaian/DoorsExpanded/archive/master.zip, enable verbose logging in RW options, load the save, play the game until an issue occurs, then Ctrl+F12 upload it here? Thanks!