search

jedahan / zr

zsh plugin manager written in rust
Mozilla Public License 2.0
180 stars 12 forks source link

Fix some file/directory issues #9

Closed SX91 closed 7 years ago

SX91 commented 7 years ago

Thanks for your awesome project, @jedahan! I've faced a several issues with zr trying to use it on my CentOS-7. And fixed them all. 😉

  1. You shouldn't really use format or any other string-based operations for path concatenation. (On my linux zr tried to write /tmpinit.zsh file)
  2. OpenOptions should be configured with create(true).truncate(true) in order to overwrite existing temp file.
  3. create_dir fails if some of the parents doesn't exist (~/.zr for example).
jedahan commented 7 years ago

Thank you so much for your contributions, and explaining them @SX91. Glad to have someone actively testing this on linux. Any other suggestions are also appreciated.