search

jedbrown / git-fat

Simple way to handle fat files without committing them to git, supports synchronization using rsync
BSD 2-Clause "Simplified" License
621 stars 137 forks source link

Add config option to allow passing --chmod to rsync #13

Closed ashokak closed 11 years ago

ashokak commented 11 years ago

I needed something like this when sharing the rsync'd location between several users, but the fat-pushed files were made as user-read-write only, which rsync dutifully reproduced in the shared location too.

I hope this is a useful thing to include.

Thanks for the handy tool; it helped us move an otherwise obstinate repo out of svn but preserve the entire history.

jedbrown commented 11 years ago

Thanks! This looks good. I wonder, would d6b87ab3e23b05adce4670dad252c5165408d9dd be enough for you?

I can imagine cases where the user has an extreme umask and thus would like to push using special permissions. There could be lots of rsync options of this form, so it might be better to have a general rsync.args config variable rather than reproducing them one at a time as they are needed.

ashokak commented 11 years ago

That change would suffice for our purposes. Thanks.

I can put together a whole change with rsync.args, if that'd be helpful. I agree that handling every possible arg to rsync would be an annoyance (and would come with order-dependent fun & games for complicated args, I think.)

jedbrown commented 11 years ago

Thanks, I updated the commit from comments, 4664f2dc2eee13b86d2e426780fd1130e0086e9f, and merged to 'master'. If you would like to implement rsync.args, I'd be happy to merge it.

jedbrown commented 11 years ago

I'm closing this pull request because the immediate problem is taken care of. Feel free to make another if you end up implementing rsync.args. Thanks.