search

jedbrown / git-fat

Simple way to handle fat files without committing them to git, supports synchronization using rsync
BSD 2-Clause "Simplified" License
621 stars 137 forks source link

README - .gitattributes should use -text, not -crlf #27

Closed ottomata closed 10 years ago

ottomata commented 10 years ago

See: https://github.com/git/git/commit/5ec3e67052289217c84e53d2cda90d939ac5725b for a discussion and more info.

jedbrown commented 10 years ago

The name -crlf is still supported, just not recommended. When I wrote this, I thought it was too soon for git-fat to break with older installations of Git (common on clusters). Is it time now? Does keeping this more compatible option hurt anything other than people that copy the attribute elsewhere? Should this wait until popular LT supported distributions have at least git v1.7.2?

ottomata commented 10 years ago

@somechris could you comment on this? Whatcha think?

somechris commented 10 years ago

I think the time to s/crlf/text/ might have come :-)

Ubuntu precise (LTS) is at 1.7.9.5-1 http://packages.ubuntu.com/precise/git

Even Debian squeeze (oldstable) is at 1.7.2.5 https://packages.debian.org/squeeze/git

I didn't check other distributions, but if even Debian oldstable has it ... is there some relevant distribution that is below 1.7.2?

jedbrown commented 10 years ago

Ubuntu 10.04 has git-1.7.0 and will be supported until this time 2015. https://wiki.ubuntu.com/LTS

RHEL6/CentOS6 has git-1.7.1. RHEL6 will be supported in "Production 2" until 2017. https://access.redhat.com/site/support/policy/updates/errata/

Sadly, antique operating systems are common on HPC systems, which is important to a nontrivial fraction of git-fat users. I'm having trouble seeing the tangible benefit of updating now in exchange for users of those systems to be forced into a workaround. The -crlf option will probably never be removed from Git. (The man page does not use the term "deprecated" and Junio has expressed that "harmless" deprecated features will probably remain forever because it's just not worth removing them.)

ottomata commented 10 years ago

Ok sounds good, let's abandon this then. Thanks!