search

jedeschaud / ct_icp

CT-ICP: Continuous-Time LiDAR Odometry
MIT License
756 stars 130 forks source link

fail to clone imgui.git #4

Closed HeXu1 closed 3 years ago

HeXu1 commented 3 years ago

Hi,thanks for your work. it seems download imgui.git failed, when I run “./ct_icp_build.sh Release "Unix Makefiles" ON ON”.

and the terminal outputs like this: [ 11%] Performing download step (git clone) for 'imgui-populate' Cloning into 'imgui-src'... Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. Cloning into 'imgui-src'... Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. Cloning into 'imgui-src'... Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. -- Had to git clone more than once: 3 times. CMake Error at imgui-subbuild/imgui-populate-prefix/tmp/imgui-populate-gitclone.cmake:31 (message): Failed to clone repository: 'git@github.com:pierdell/imgui.git'

hope for your reply. thanks.

pdell-kitware commented 3 years ago

Hi @HeXu1,

We used the ssh link for imgui gitub projects, so you have this problem because you have not setup your ssh key to connect to your github account.

I changed the default option to use the ssh link to the git repositories to a more standard "https" link,

So this should work for you now,

Keep me posted,

Pierre

HeXu1 commented 3 years ago

@pdell-kitware yes it works,but it seems has some link errors.

it outputs like follows at the end of building works.

CMakeFiles/slam.dir/slam.cpp.o: In function YAML::TypedBadConversion<float>::~TypedBadConversion()': slam.cpp:(.text._ZN4YAML18TypedBadConversionIfED2Ev[_ZN4YAML18TypedBadConversionIfED5Ev]+0xb): undefined reference toYAML::BadConversion::~BadConversion()' CMakeFiles/slam.dir/slam.cpp.o: In function YAML::TypedBadConversion<float>::~TypedBadConversion()': slam.cpp:(.text._ZN4YAML18TypedBadConversionIfED0Ev[_ZN4YAML18TypedBadConversionIfED5Ev]+0xf): undefined reference toYAML::BadConversion::~BadConversion()' CMakeFiles/slam.dir/slam.cpp.o: In function `YAML::TypedBadConversion::~TypedBadConversion()':

pdell-kitware commented 3 years ago

I cannot replicate this build error,

Can you tell me what are your system specifications (cmake version / ubuntu version / etc ...)?

This is a linking error, and there might be a problem importing the dependency yaml-cpp.

Can you verify:

  1. If yaml-cpp has been correctly installed by the superbuild ? You should have the following library (in the build directory cmake-build-Release by default): /external/install/Release/yaml-cpp/libyaml-cpp.a 2. If the yaml-cpp found by find_package(yaml-cpp ...) in cmake/external.cmake is indeed the one from the superbuild. (You can try to add message(FATAL_ERROR ${YAML_CPP_INCLUDE_DIR})) to external.cmake after the find_package command. It should point to the include directory where the yaml-cpp headers are located
HeXu1 commented 3 years ago

Hi, thanks . my system is Ubuntu 16.04, cmake version is 3.18

1) I can find the /external/install/Release/yaml-cpp/libyaml-cpp.a file 2) the output is “/usr/lib/x86_64-linux-gnu/cmake/yaml-cpp/../../../../include” ,it is the system yamlLIB.

pdell-kitware commented 3 years ago

Yes that is what I thought. We need to force cmake to use the built yaml-cpp file. I still cannot replicate the bug, even after installing yaml-cpp on my system.

Can you try the branch fix_4 ? #5

It should force cmake not to use the system library (plus I corrected the path to the yaml-cppConfig.cmake file)

(You might need to clean your build files, to remove cached variables)

HeXu1 commented 3 years ago

@pdell-kitware yes,it works. thanks a lot!