search

jedeschaud / ct_icp

CT-ICP: Continuous-Time LiDAR Odometry
MIT License
737 stars 126 forks source link

Pybind issue #50

Open XMU-qcj opened 1 year ago

XMU-qcj commented 1 year ago

Thank you very much for your work! I didn't find any bindings to python in the compile command you provided, am I missing something?

pdell-kitware commented 1 year ago

Hi,

The python bindings were available in a previous version, And we have yet to reimplement them,

To be honest, it wasn't very high our long list of priorities, as we didn't expect them to be much used.

But if you are interested, I can start working on them again (this should be available next week)

Let me know,

Cheers

dandric commented 1 year ago

I'm interested to have 1/ python bindings for the current version and 2/ it would help with related work in pyLiDAR-SLAM too. Please let me know what are the next steps, and the time frame. If that need time, some direction how to do it on current versions would help.

pchundi commented 1 year ago

+1 for fixing the Python bindings in the latest version

pdell-kitware commented 1 year ago

Hi,

Ok then ! So I'll start working on it by the end of the week, it should be ready at the latest early next week.

In the mean-time, to do the binding I used pybind11, the previous version is accessible at: https://github.com/jedeschaud/ct_icp/tree/old_master/src/binding

pchundi commented 1 year ago

@pdell-kitware: thank you for prioritizing this issue! Anyway I can help?

pdell-kitware commented 1 year ago

Started working on it, see PR #56

I'll notify this issue when I am done

pdell-kitware commented 1 year ago

Hi, So a first version of the binding is completed for CT-ICP,

See the branch python_bindings, there are some explanations in the Readme.md,

I'll try to integrate update the binding to pyLiDAR-SLAM in the week (I need to update the binding which have different function names, and methods)

JUN1026 commented 1 year ago

First of all thanks a lot for the author's work, I recently tried ct-icp and pyLiDAR and tried to call ct-icp in pyLiDAR.

I spent a lot of time trying pybind but failed, and finally found out that the project's bindings folder was updated two years ago, so many functions were having problems. In the previous comment, pdell-kitware said that the bindings file will be updated, I would like to know where the last updated file is available? How does the final combination with pyLiDAR work?

I would be grateful if you could answer my questions.

friendship1 commented 1 year ago

First of all thanks a lot for the author's work, I recently tried ct-icp and pyLiDAR and tried to call ct-icp in pyLiDAR.

I spent a lot of time trying pybind but failed, and finally found out that the project's bindings folder was updated two years ago, so many functions were having problems. In the previous comment, pdell-kitware said that the bindings file will be updated, I would like to know where the last updated file is available? How does the final combination with pyLiDAR work?

I would be grateful if you could answer my questions.

same here, Which is the "latest version" and which is the "first version"? I couldn't find any branches or tags related to it.