jedfoster / SassMeister

The Sass playground
http://sassmeister.com
199 stars 25 forks source link

Refactor the "Your gist is ready" modal dialog #58

Closed lolmaus closed 10 years ago

lolmaus commented 10 years ago

Currently the "Your gist is ready" modal dialog contains two links:

Both links are bad, and the dialog should feel bad.

The link to gist should be moved to the "cloud" menu where it belongs. That's where any person would look for it.

Also, there's a big problem with the link to gist being unavailable. When a user opens another user's SassMeister project and wants visit its gist, there is no way he can do that. He can only fork the project, then he will be able to click the link in the "Your gist is ready" modal dialog. But it will be a different gist! What if he wants to comment on the original gist or learn about its author?

The link to the current SassMeister project should not exist in the first place. Its problem is that it forces the page to reload (for me it's 13 requests, ~250KB and five seconds; why isn't app.js being cached?). But why reload in the first place? It brings me to absolutely the same page where i was before i clicked the link! Also, SassMeister updates its URL, so i can just copy it from the browser's URL bar.

TL/DR:

  1. Add a "Go to gist" link to the "cloud" menu.
  2. Replace the "Your gist is ready" modal dialog with a non-blocking and self-dismissing notification. It should not contain a link that causes SassMeister to reload.

PS This is just a suggestion for you to consider, i wasn't intending to be bossy.

jedfoster commented 10 years ago

Pull requests are always welcome. This is something I've been meaning to add, but it's currently a low priority for me. If you'd like to add it, please feel free to do so and submit a PR.

And yes, app.js should be cached. Not sure why it isn't. Probably not sending the correct headers.

jedfoster commented 10 years ago

I'd also note that the modal dialog notification will be reworked in a future release.

jedfoster commented 10 years ago

These have all been addressed with the latest release.