jedi-gg / swgoh.gg.public

SWGOH.GG Issues
https://swgoh.gg
42 stars 12 forks source link

cookies and adds problem #539

Closed CountTimon closed 2 years ago

CountTimon commented 5 years ago

On the site swgoh.gg shows up "Ads help us run this site" and then you read everythin and still pops up every time I try to find somethin. Please can you fix that.

Thank you and kind regards,

Timon Turk

acrofales commented 5 years ago

Yeah. Have the same issue. Both on mobile (Chrome in Android) and on pc-based browsing (Chrome and Firefox in Windows and Linux. Haven't tried Edge). Asked in guildchat and I am also not the only one there. This is probably affecting a lot of people.

CountTimon commented 5 years ago

Yes a lot of people with same problem in our guild too. :) thanks for quick replay.

On Thu, May 9, 2019 at 1:25 PM acrofales notifications@github.com wrote:

Yeah. Have the same issue. Both on mobile (Chrome in Android) and on pc-based browsing (Chrome and Firefox in Windows and Linux. Haven't tried Edge). Asked in guildchat and I am also not the only one there. This is probably affecting a lot of people.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jedi-gg/swgoh.gg.public/issues/539#issuecomment-490864364, or mute the thread https://github.com/notifications/unsubscribe-auth/AMA4MR7RRG3LLS54UX4FLALPUQC2NANCNFSM4HLZPX5Q .

-- Timon Turk

Milčinskega ulica 79 SI-1000 Ljubljana M: +386 40 321 229 E: timion1@gmail.com

sanktanglia commented 5 years ago

We just recently swapped ad providers, so there must be some issue with their cookie detection. Can someone post a screenshot of what they are seeing? Also can you check for javascript errors and confirm you have cookies enabled? Thanks!

CountTimon commented 5 years ago

[image: slika.png] [image: slika.png]

On Thu, May 9, 2019 at 9:16 PM sanktanglia notifications@github.com wrote:

We just recently swapped ad providers, so there must be some issue with their cookie detection. Can someone post a screenshot of what they are seeing? Also can you check for javascript errors and confirm you have cookies enabled? Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jedi-gg/swgoh.gg.public/issues/539#issuecomment-491031341, or mute the thread https://github.com/notifications/unsubscribe-auth/AMA4MR72K747RYFOHQQORQTPUR2BHANCNFSM4HLZPX5Q .

-- Timon Turk

Milčinskega ulica 79 SI-1000 Ljubljana M: +386 40 321 229 E: timion1@gmail.com

acrofales commented 5 years ago

Screenshot from 2019-05-10 15-31-10

On mobile it's similar, but can't see JS output, as I don't know how to open the console on mobile, not sure it's possible. Anyway, on desktop there are no errors, but there are a bunch of warnings about content and XSS.

I confirm I have cookies enabled.

sanktanglia commented 5 years ago

Are people still having this issue? Our ad provider got back to us and said they pushed out some new code so if you clear cache should fix it. Let me know if anyone is still seeing it

CountTimon commented 5 years ago

I stil have the same pop up problem. :(

On Mon, May 13, 2019 at 9:09 PM sanktanglia notifications@github.com wrote:

Are people still having this issue? Our ad provider got back to us and said they pushed out some new code so if you clear cache should fix it. Let me know if anyone is still seeing it

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jedi-gg/swgoh.gg.public/issues/539?email_source=notifications&email_token=AMA4MR54SFF6JETM6F4NRMLPVG4IHA5CNFSM4HLZPX52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVJITCA#issuecomment-491948424, or mute the thread https://github.com/notifications/unsubscribe-auth/AMA4MR6JMTPRIVVYYY5UCG3PVG4IHANCNFSM4HLZPX5Q .

-- Timon Turk

Milčinskega ulica 79 SI-1000 Ljubljana M: +386 40 321 229 E: timion1@gmail.com

acrofales commented 5 years ago

It solved it for me after I deleted cookies (not just cache). Both on mobile and on desktop. Will ask in guild chat if people still have problems.