search

jedi-gg / swgoh.gg.public

SWGOH.GG Issues
https://swgoh.gg
42 stars 12 forks source link

Not distinguishing between similar named characters in GAC Meta section #721

Open amonline1 opened 3 years ago

amonline1 commented 3 years ago

There's an issue with searching for squad line-ups in the GAC Meta feature of the site whereby similarly named characters are not being distinguished between. The prime example of this is Rey (galactic legend) and Rey (Scavenger), if you try and search for a squad containing both it identifies the selection of Rey (Scavenger) as simply Rey and so does not show you those Rey lead squads which contain Rey (Scavenger). I'm sure I've seen this happen before with other similar characters like Finn or Poe or Kylo etc. but can't remember at the moment which ones it was on, but definitely an issue with Rey and Rey (Scavenger)

Example: https://swgoh.gg/gac/counters/GLREY/?d_unit=EPIXFINN&d_unit=EPIXPOE&d_unit=AMILYNHOLDO&d_unit=REY

Please read the FAQs in this repo's README before posting.

Also, if submitting a problem with user data, -PLEASE- include the URL of affected data.

WITHOUT URLS, YOUR TICKET WILL NOT BE RESPONDED TO

LOOK THROUGH EXISTING TICKETS TO ENSURE YOUR ISSUE HAS NOT ALREADY BEEN CREATED

danpaulson commented 3 years ago

Good find! I've added a ticket to fix, though the solution will be slightly complex so no ETA.