search

jedi-gg / swgoh.gg.public

SWGOH.GG Issues
https://swgoh.gg
41 stars 12 forks source link

api/abilities/ no longer supports zeta or omicron filters #779

Closed driderdesigns closed 1 year ago

driderdesigns commented 1 year ago

The abilities API used to allow optional URL params to restrict the data being returned. The filters worked a few days ago; I noticed them broken last night.

https://swgoh.gg/api/abilities/ STILL WORKS https://swgoh.gg/api/abilities/?is_zeta=true BROKEN https://swgoh.gg/api/abilities/?is_omicron=true BROKEN

Filtering on either ability type now returns: {"data":null,"message":"Server Error"}

scobenes commented 1 year ago

sorry about that. its fixed

driderdesigns commented 1 year ago

Damn, you are like FAST fast! Thanks for the assist!!

driderdesigns commented 1 year ago

GL Ultimate abilities are being returned by both filters, they're in each list twice actually.

https://swgoh.gg/api/abilities/?is_omicron=true returns this, twice. I can add a prop check in code, but figure you might want to look on your end?

{ "base_id": "ultimateability_supremeleaderkyloren", "ability_id": "ultimateability_supremeleaderkyloren", "name": "Depths of Rage", "image": "https://game-assets.swgoh.gg/tex.ability_kyloren_tros_ultimate.png", "url": "//swgoh.gg/characters/supreme-leader-kylo-ren/", "tier_max": 1, "is_zeta": false, "is_omega": false, "is_omicron": false, "is_ultimate": true,

scobenes commented 1 year ago

Ah yea, I don't really use these filters for anything, so I didn't test something I changed super closely. Fixed a logic issue and I think it should be back to normal now

driderdesigns commented 1 year ago

Solid! Sounds like may day-to-day LOL.

I've got a roster progress site that tracks GL progress, Zetas, Omicrons, and meta teams. https://swgoh.driderdesigns.com/

Thanks again!