search

jedi4ever / sahara

a plugin for vagrant that allows you manage a sandbox state
732 stars 52 forks source link

support kvm provider #32

Open miurahr opened 10 years ago

miurahr commented 10 years ago

support KVM provider

I need to rename Libvirt as ProviderLibvirt to name congestion, because ruby-libvirt has Libvirt namespace.

Signed-off-by: Hiroshi Miura miurahr@linux.com

jedi4ever commented 10 years ago

@miurahr we can't automerge, could you rebase?

miurahr commented 10 years ago

rebased.

jedi4ever commented 10 years ago

thx @miurahr , if some-one else can confirm and test this.

miurahr commented 10 years ago

Any progress?

aspiers commented 9 years ago

This PR doesn't make sense to me:

  1. There is no namespace conflict because ruby-libvirt uses ::Libvirt which is different from Sahara::Session::Libvirt.
  2. It adds lib/sahara/session/kvm.rb which does not contain KVM-specific code, only libvirt code.

What am I missing?

aspiers commented 9 years ago
  1. It adds lib/sahara/session/kvm.rb which does not contain KVM-specific code, only libvirt code.

What am I missing?

Oh I see, I was missing that this is adding support for vagrant-kvm, which just like vagrant-libvirt, uses libvirt as the backend. However my first question about the (lack of) namespace conflict still stands.

Also it doesn't seem good that this is mostly a copy'n'paste from lib/sahara/session/libvirt.rb - surely it could inherit from Sahara::Session::ProviderLibvirt and then override the necessary bits?