jedi4ever / veewee

Easing the building of vagrant boxes
MIT License
4.29k stars 779 forks source link

Update Gentoo kernel version, fix networking, and add minimal box template #1018

Closed courtney-miles closed 9 years ago

courtney-miles commented 9 years ago

This PR includes the following Gentoo template changes:

mpapis commented 9 years ago

can you reconsider to merge the templates in similar manner as https://github.com/jedi4ever/veewee/tree/master/templates/openSUSE-13.1 (definition.rb)

courtney-miles commented 9 years ago

I don't mind doing that.

Would you mind if I do that in a separate PR? I would want to do more testing after that change.

Currently the Gentoo Templates don't function at all, so this PR gets them functioning again and has been tested.

courtney-miles commented 9 years ago

Hi @mpapis ,

I'm afraid my lack of knowledge in Ruby is proving to be a significant road block in my ability to merge the Gentoo templates.

I'm hoping you might be able to offer some simple code sample to get me started.

The current definition.rb file dynamically sets the iso_file and iso_src to get the latest gentoo image. A part of merging the template will require knowing the intended architecture to determine the iso_file and iso_src.

What I have been trying to do is specify the architecture in the yml files that would distinguish each variation. I have tried to put it in params:

:os_type_id: 'Gentoo_64'
# ...
:params:
  architecture: 'amd64' 

Then in definition.rb

require 'net/http'
Veewee::Definition.declare_yaml('definition.yml', 'gentoo_amd64_minimal.yml')
template_arch  = Veewee::Definition.params["architecture"]
# ...

I'm capable of figuring this out, but that won't happen until I have a day to sit down and learn some Ruby. So I'm hoping you could point me the right way.

mpapis commented 9 years ago

lets split it in two steps:

  1. please merge the templates using hard-coded template iso file/url for the latest available one
  2. open a ticket for veewee to support:

    :iso_src => [:gentoo, 'http://distfiles.gentoo.org/releases/amd64/autobuilds', 'latest-install-amd64-minimal.txt'],

    this way veewee would know the target file is only a "link" and to re evaluate it's content + to set the :iso_file to the file name of the link

courtney-miles commented 9 years ago

Thankyou, Michal. I will do exactly that. I appreciate your guidance.