search

jedi4ever / veewee

Easing the building of vagrant boxes
MIT License
4.29k stars 779 forks source link

Added ubuntu-12.04.5 amd and i386 templates #1095

Open gkumar48 opened 8 years ago

gkumar48 commented 8 years ago

Added new ubuntu-12.04.5 amd and i386 templates.

Old iso files are not available any more.

mpapis commented 8 years ago

any chance you could merge them like it's done here: https://github.com/gkumar48/veewee/blob/ubuntu-12.04.5/templates/CentOS-5.10/definition.rb?

gkumar48 commented 8 years ago

I have made the changed as per your suggestions.

mpapis commented 8 years ago

now you could merge those two directories into one! in fact you could even merge previous versions too! all into one directory for ubuntu-12.04 :) the biggest benefit of the yml files is that it's easy to compose multiple configurations that have a lot of repeating parts :)

gkumar48 commented 8 years ago

I don't see the merge pull request, it looks like I don't have write access to the repo. Is it possible for you to do the merge?

mpapis commented 8 years ago

yes, only maintainers can merge pull requests, as I wrote in previous comment it would be the best if you merged the two directories, the work is not done, it can be improved a lot.

gkumar48 commented 8 years ago

I will try to find sometime and do it this weekend. thanks