fix(table): SuppressTrailingSpaces also removed spaces from the beginning

jedib0t / go-pretty

Table-writer and more in golang!

MIT License

2.82k stars 113 forks source link

fix(table): SuppressTrailingSpaces also removed spaces from the beginning #295

Closed ilya-lesikov closed 7 months ago

ilya-lesikov commented 7 months ago

Proposed Changes

mytable.SuppressTrailingSpaces() suppressing not only trailing spaces, but also spaces from the beginning. This fixes it.

Before fix

RESOURCE (→READY)               STATE    INFO
Deployment/lesikovtestttt       WAITING  Ready:0/1
• Pod/lesikovtestttt-78568f8d  CREATED  Status:CrashLoopBack
77-dkznh                                 Off  Errors:1  LastE
rror:"CrashLoopBackO
ff: back-off 5m0s re
starting failed cont
ainer=alpine pod=les
ikovtestttt-78568f8d
77-dkznh_nelm-basic(
a1e1ac7e-c64d-4531-9
d0d-b20b5e9f0a61)"

After fix

RESOURCE (→READY)               STATE    INFO
Deployment/lesikovtestttt       WAITING  Ready:0/1
 • Pod/lesikovtestttt-78568f8d  CREATED  Status:CrashLoopBack
77-dkznh                                 Off  Errors:1  LastE
                                         rror:"CrashLoopBackO
                                         ff: back-off 2m40s r
                                         estarting failed con
                                         tainer=alpine pod=le
                                         sikovtestttt-78568f8
                                         d77-dkznh_nelm-basic
                                         (a1e1ac7e-c64d-4531-
                                         9d0d-b20b5e9f0a61)"

ilya-lesikov commented 7 months ago

I see some units failing since they for some reason expect SuppressTrailingSpaces to also remove spaces in the beginning. I'll fix the tests if you are fine with the PR.

jedib0t commented 7 months ago

@ilya-lesikov Code looks okay to me, but you have to fix the failing unit-test along with it. Change the code in the test from:

    tw.Style().Options = OptionsNoBordersAndSeparators
    compareOutput(t, tw.Render(), `
ID    TEXT1                                   DATE              TEXT2
U2    Hey                                     2021-04-19 13:37  Yuh yuh yuh
S12   Uhhhh                                   2021-04-19 13:37  Some dummy data here
R123  Lobsters                                2021-04-19 13:37  I like lobsters
R123  Some big name here and it's pretty big  2021-04-19 13:37  Abcdefghijklmnopqrstuvwxyz
R123  Small name                              2021-04-19 13:37  Abcdefghijklmnopqrstuvwxyz`)

to:

    tw.Style().Options = OptionsNoBordersAndSeparators
    compareOutput(t, tw.Render(), `
 ID    TEXT1                                   DATE              TEXT2
 U2    Hey                                     2021-04-19 13:37  Yuh yuh yuh
 S12   Uhhhh                                   2021-04-19 13:37  Some dummy data here
 R123  Lobsters                                2021-04-19 13:37  I like lobsters
 R123  Some big name here and it's pretty big  2021-04-19 13:37  Abcdefghijklmnopqrstuvwxyz
 R123  Small name                              2021-04-19 13:37  Abcdefghijklmnopqrstuvwxyz`)

The new code has leading spaces in each line of output.