jedib0t / go-pretty

Table-writer and more in golang!
MIT License
3.06k stars 120 forks source link

feat: adding batch display on enter #325

Closed jeff06 closed 2 months ago

jeff06 commented 4 months ago

If outputmirror is set, and there is a batchsize that has been set (SetBatchSize(6)), element will be displayed according to this. This exclude header and footer.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 10169684130

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
table/table.go 5 22 22.73%
<!-- Total: 5 22 22.73% -->
Totals Coverage Status
Change from base Build 8953482681: -0.5%
Covered Lines: 3557
Relevant Lines: 3574

💛 - Coveralls
sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jedib0t commented 4 months ago

Thanks for the contribution. But I feel there may be a better way to do this without changing existing interfaces. Give me a few days to think about this. Busy with real world stuff. :(

jeff06 commented 3 months ago

Hello,

Hope everything is ok. I was Curious about the status of this PR.

Thank,

jedib0t commented 3 months ago

Hey really sorry about the delay. I started working on an alternate implementation last week that would give you a "Pager" which will let you go back and forth in pages. But I never got around to completing it due to personal reasons. I promise to get back to you by this weekend. 🤞

jedib0t commented 3 months ago

Hey @jeff06 sorry for the delay. I've pushed an initial draft of my changes to the pager branch @ https://github.com/jedib0t/go-pretty/tree/pager. Specific commit: https://github.com/jedib0t/go-pretty/commit/d2e7d2493480beb88a7755619ab33687ceb4c8cd -- please take a look and let me know if this serves your purpose. I'll then merge it to the main branch.

jeff06 commented 2 months ago

Hi, Yes it does, thank you so much