table: ignore non-printable characters when suppressing empty columns

jedib0t / go-pretty

Table-writer and more in golang!

MIT License

3.06k stars 120 forks source link

table: ignore non-printable characters when suppressing empty columns #327

Closed iamjoemccormick closed 3 months ago

iamjoemccormick commented 3 months ago

Proposed Changes

This change ensures that non-printable characters (e.g., text direction markers) are ignored when determining whether to suppress empty columns. This is required to use FormatOptions.Direction in conjunction with SuppressEmptyColumns().

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10482223208

Details

8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 8953482681:	0.0%
Covered Lines:	3561
Relevant Lines:	3561

💛 - Coveralls

jedib0t commented 3 months ago

Thanks for your contribution. Will cut a release later this week with this change incorporated.