Closed naegelyd closed 8 years ago
Cool! I will take a look at this this week.
Thanks for the contribution!
A little bit boring is the mix of code changes and code-format/whitespace changes :(
Do you see a way to split code changes from format changes?!?
Do you see a way to split code changes from format changes?!?
Sure, I can squash the lint related commits to a single change and then you can decide whether to include it in this PR, include it in a different PR, or discard it altogether.
Squash all lint related commits, is a good idea!
@jedie Thanks for the quick review. As much as possible, I have removed lint changes from this PR and removed the flake8
step from tox
and travis
files. The diff is now much smaller and, I think, manageable. I cherrypicked the changes onto a different local branch so I can submit a followup PR if you would like to add flake8
to the test pipeline and include those changes there. Some changes(like trailing whitespace removal) were included in other commits and I've left them in because of the difficulty in separating them but I think given the new diff size, that this might be OK.
@jedie - Friendly ping
Thanks for the ping ;)
I upload the new v0.30.0 release: https://pypi.python.org/pypi/django-tools/0.30.0
I upload the new v0.30.0 release: https://pypi.python.org/pypi/django-tools/0.30.0
Awesome. Thanks @jedie!
@jedie
This PR adds support for Django 1.9 and drops support for Django < 1.8. From the tests alone, there does not appear to be any issue with Django 1.9. In addition, this PR does some general cleanup including but not limited to:
flake8
as part of the test processAdditionally, this PR fixes all the broken tests as best I could figure them and adds Python 3 support. While the test coverage is still not that high, all tests are passing on this PR.