Django 1.9 and Python 3 support

jedie / django-tools

miscellaneous django tools

http://pypi.python.org/pypi/django-tools/

Other

128 stars 31 forks source link

Django 1.9 and Python 3 support #9

Closed naegelyd closed 8 years ago

naegelyd commented 8 years ago

@jedie

This PR adds support for Django 1.9 and drops support for Django < 1.8. From the tests alone, there does not appear to be any issue with Django 1.9. In addition, this PR does some general cleanup including but not limited to:

Adding a toxfile for local testing
Adding flake8 as part of the test process
Ignoring some IDE specific files

Additionally, this PR fixes all the broken tests as best I could figure them and adds Python 3 support. While the test coverage is still not that high, all tests are passing on this PR.

coveralls commented 8 years ago

Changes Unknown when pulling c924ee77c8c6cb5b56aeb293fa1d0cca44ebab78 on naegelyd:django-1.9-support into \ on jedie:master**.

coveralls commented 8 years ago

Changes Unknown when pulling d0a720e9aa248ac3680b0ea8ca086663a733a0b4 on naegelyd:django-1.9-support into \ on jedie:master**.

coveralls commented 8 years ago

Changes Unknown when pulling 22c23b80c5378f08e133affb2714530344d0bbd1 on naegelyd:django-1.9-support into \ on jedie:master**.

coveralls commented 8 years ago

Changes Unknown when pulling c8fc8b2a3b5975f100a02e92b3bc9baf4b77e366 on naegelyd:django-1.9-support into \ on jedie:master**.

coveralls commented 8 years ago

Changes Unknown when pulling 6f0a1824061fe477bed70dc1d9b7a71e3d0cc58e on naegelyd:django-1.9-support into \ on jedie:master**.

coveralls commented 8 years ago

Changes Unknown when pulling 8350488dbca76d3b1676d45c1b5af6d4f9c0bafd on naegelyd:django-1.9-support into \ on jedie:master**.

jedie commented 8 years ago

Cool! I will take a look at this this week.

coveralls commented 8 years ago

Changes Unknown when pulling 3164ec2413dcf252194f853f102803af7aebc9f1 on naegelyd:django-1.9-support into \ on jedie:master**.

jedie commented 8 years ago

Thanks for the contribution!

A little bit boring is the mix of code changes and code-format/whitespace changes :(

Do you see a way to split code changes from format changes?!?

naegelyd commented 8 years ago

Do you see a way to split code changes from format changes?!?

Sure, I can squash the lint related commits to a single change and then you can decide whether to include it in this PR, include it in a different PR, or discard it altogether.

coveralls commented 8 years ago

Changes Unknown when pulling af045a02ea2caf6a1278c55349cd6d3d5777b4a0 on naegelyd:django-1.9-support into \ on jedie:master**.

jedie commented 8 years ago

Squash all lint related commits, is a good idea!

naegelyd commented 8 years ago

@jedie Thanks for the quick review. As much as possible, I have removed lint changes from this PR and removed the flake8 step from tox and travis files. The diff is now much smaller and, I think, manageable. I cherrypicked the changes onto a different local branch so I can submit a followup PR if you would like to add flake8 to the test pipeline and include those changes there. Some changes(like trailing whitespace removal) were included in other commits and I've left them in because of the difficulty in separating them but I think given the new diff size, that this might be OK.

coveralls commented 8 years ago

Changes Unknown when pulling 9be86fc1858ee5c200afb65791bfbea018f1b907 on naegelyd:django-1.9-support into \ on jedie:master**.

naegelyd commented 8 years ago

@jedie - Friendly ping

jedie commented 8 years ago

Thanks for the ping ;)

jedie commented 8 years ago

I upload the new v0.30.0 release: https://pypi.python.org/pypi/django-tools/0.30.0

naegelyd commented 8 years ago

I upload the new v0.30.0 release: https://pypi.python.org/pypi/django-tools/0.30.0

Awesome. Thanks @jedie!