Vedant's first contribution

jedieaston / WinGetHelpers

A PowerShell (5.1+) module with several helper functions for writing and updating WinGet manifests.

Other

7 stars 3 forks source link

Vedant's first contribution #4

Closed vedantmgoyal9 closed 2 years ago

vedantmgoyal9 commented 3 years ago

I kept the PR title so because this PR does many things which cannot be described in the title.

vedantmgoyal9 commented 3 years ago

@jedieaston Would you like to give it a go?

jedieaston commented 3 years ago

I can attempt to review it sometime this week, but can you summarize what you did? Since I don't have a test suite I can't automatically review your changes to make sure functionality wasn't broken.

vedantmgoyal9 commented 3 years ago

Update documentation (README.md)
Add CODEONWERS so that we don't need to comment "@jedieaston please review/take a look upon it" and can directly request a review from you
Add PSScriptAnalyser to ensure code quality
Add GitHub Pages theme "Cayman" because it makes documentation easier to read.
OTBS indentation for psm1 and psd1 files

vedantmgoyal9 commented 2 years ago

@jedieaston just writing this comment to remind you that you've to review it.

vedantmgoyal9 commented 2 years ago

@jedieaston Is there anything I've done wrong? I don't think I've made any BREAKING changes.

vedantmgoyal9 commented 2 years ago

@jedieaston I've made the changes to the documentation. However, I have changed the language a bit.