jedileesang / dvp-u3-constellations

0 stars 0 forks source link

Constellations Project DVP Review #1

Open cviddy17 opened 6 years ago

cviddy17 commented 6 years ago

Criteria 1: Matplotlib and CSV Score Level: 4 Exceeds Expectations Comment(s): The inline command is included as well as all of the other import commands. Great job!

Criteria 2: Implementation of 2D Visualization Score Level: 3 Comment(s): The 2D grid appears as expected, however, the subplot was implemented incorrectly. Note this is corrected during the 3D Implementation. Please also add a title to this visualization.

Criteria 3: Implementation of 3D Visualization Score Level: 3 Comment(s): The 3D grid appears, as expected, however, a title is missing. Also, stating the x,y,z coordinates again is redundant.

Overall Score: 10/12 Great job! All the libraries were properly added and the inline property %matplotlib notebook allowed for the visualization to become interactive. Note that when working with jupyter notebooks, it is important that the final file should be saved in .ipynb instead of .py format, and that it is not necessary to reload the data in every cell, as long as all cells are run inside the notebook.

jedileesang commented 6 years ago

I would like to know what was wrong with the subplot in criteria 2. It returned same result with/without subplot. Please explain in detail. Also I have a question in the criteria 3 and left comment.

I don't understand what this mean. "Create a new variable constellation3d and call the scatter function with your x, y and z coordinates." it specifically ask to create new variable constellation3d, however, I dont understand what this mean and how.

cviddy17 commented 6 years ago

Section 2: The instructions were to add the subplot in the code. But you are correct in that it outputs the same result either way.

Section 3 should look like this:

fig_3d = plt.figure() constellation3d = fig_3d.add_subplot(1,1,1,projection="3d") constellation3d.scatter(x,y,z) plt.show()

where you call an instance of fig_3d. This is useful if you had more than one 3d figure you wanted to put into a subplot grid. Again, not necessary for this exercise, but useful in the future.