jediminer543 / JMT-MCMT

A multithreading mod for for Minecraft forge 1.15.2 and 1.16.x
https://www.curseforge.com/minecraft/mc-mods/mcmt-multithreading
BSD 2-Clause "Simplified" License
227 stars 19 forks source link

Fabric Port? #10

Open Shroototem opened 4 years ago

Shroototem commented 4 years ago

Are there any plans to port this to fabric?

jediminer543 commented 4 years ago

This is going on the long term enhancement list it'll get the same treatment as #2. I.e. once the current release build is stable and ready I'll work on cross porting it (though I think a back to 1.12.2 port is in order first)

The main issue with this is I've never used fabric before so I'd need to learn how it does it's code transformation and if it can do what I want it to do (as forge gives me a full scriptable api to rewrite entire classes if I need to (modulo issues))

And if anyone wants help replicating MCMT in fabric themselves, the "ask for help and I'll do what I can" of #2 also applies (But I know more about 1.12.2 coremodding than fabric coremodding)

KubiRemPL commented 4 years ago

I think 1.12.2 forge has more priority cuz lots of good mods and modpacks need this mod. Fabric has alot of optimization mods already that will help U.

Shroototem commented 4 years ago

But we could always use more. XD I'm trying to get the lowest MSPT possible on my server. Really just for overhead.

Titaniumtown commented 4 years ago

This should really get a fabric port!

Ytoblo commented 3 years ago

This should really get a fabric port!

No, just no

Titaniumtown commented 3 years ago

@Ytoblo why not?

Ytoblo commented 3 years ago

@Ytoblo why not?

better let a person work on the mod loader on which he is comfortable, with which he is very familiar, and not which "becomes popular". I understand why you need this mod for fabric, you have no experience with forge mappings, and therefore you need fabric for parallel ticks of you server software

Ytoblo commented 3 years ago

am i right?

Titaniumtown commented 3 years ago

lol

KubiRemPL commented 3 years ago

Yeah U are right @Ytoblo . Forge will be better cuz author knows it. We should first get stable release on modern minecraft versions and then backport to 1.12.2 as somebody sad in another issue. Fabric has alot of optimization mods, and they are enough cuz there are no "big" mods on fabric.

Shroototem commented 3 years ago

That's fair enough. I just always want my servers to run with max performance in mind.

himekifee commented 3 years ago

I'd like to help porting it to fabric. I had some fabric experience and willing to know more about Minecraft mechanisms.

himekifee commented 3 years ago

I did the first release of my porting. It can be found at MCMTFabric. For some reason, it doesn't seem to be working and proper logging and configuration loading is in progress.

jediminer543 commented 3 years ago

@himekifee

Oooooh, very Jazzy, I'll try having a look at the code properly tomorrow

One thing I would note is that your code lacks the ability at present to effectively perform the functionality of sync_fu

But props to you for making it work; if you want to talk, please yell; I'm working on setting up a discord server, but DMs can work before then if needs be