search

jediminer543 / JMT-MCMT

A multithreading mod for for Minecraft forge 1.15.2 and 1.16.x
https://www.curseforge.com/minecraft/mc-mods/mcmt-multithreading
BSD 2-Clause "Simplified" License
228 stars 18 forks source link

Auto blacklist erroring entities #80

Closed meta1203 closed 3 years ago

meta1203 commented 3 years ago

Just like the title says: if an entity causes an exception in the default SerDes filter, automatically add it to the blacklist

This also adds the blacklisted entity to its own config file to persist between sessions.

(It ALSO fixes a bug related to nightconfig's TOML implementation & Java's internal Map object)

jediminer543 commented 3 years ago

You work fast

I'm curently reading through it now but most of it looks okay, I've added a comment to one of the things that's a bit broken, could you say something about it being licenced under BSD-2-Clause License in a comment just so I don't need to worry about wierd legal shenanagins (as IDK how well infering it from your repo works legally and I've seen bad things happen).

I've added a comment about a thing that probs needs changing; I'll try double checking everything through more again just to check. Once that's fixed and I'm not worrying about legal things I can merge it.

meta1203 commented 3 years ago

@jediminer543 Went ahead and fixed that bug, thanks for catching that. I also added that license acknowledgement for you (lemme know if you need me to put it elsewhere). I wouldn't ever try to undermine an OSS project, but after what happened with CraftBukkit I don't blame you for being cautious.