search

jedireza / aqua

:bulb: A website and user system starter
https://jedireza.github.io/aqua/
MIT License
1.38k stars 356 forks source link

Fix access to props on reset page #194

Closed vkvam closed 7 years ago

vkvam commented 7 years ago

Small bug noticed when trying to reset password.

jedireza commented 7 years ago

So was this not a bug?

vkvam commented 7 years ago

There is, I just have very little experience with React (or frontend in general) and was a bit trigger happy with the pull-request. Tests where failing, and from other examples seen, the existing code should work. I'll go through some react tutorials later on and may update the pull request if I feel confident with the fix.

Feel free to tackle it yourself.

jedireza commented 7 years ago

Oh I see. Thanks for reporting and creating a PR was a great idea. I opened #195 to track this.

vkvam commented 7 years ago

Looks to be a react router v4 related bug: https://jaketrent.com/post/access-route-params-react-router-v4/.

I've updated tests and propTypes.

jedireza commented 7 years ago

Thanks!