jedireza / aqua

:bulb: A website and user system starter
https://jedireza.github.io/aqua/
MIT License
1.38k stars 356 forks source link

cheap-module-source-map for production ? #255

Closed adantoscano closed 6 years ago

adantoscano commented 7 years ago

Hi, I found in webpack that it declares mapping with "source-map" option in dev mode and cheap-module-source-map for production. Shoudn't be the opposite?

    let devtool = 'source-map';

    if (process.env.NODE_ENV === 'production') {
        plugins.push(new Webpack.optimize.UglifyJsPlugin({
            compress: {
                warnings: false
            }
        }));

        devtool = 'cheap-module-source-map';
    }
jedireza commented 7 years ago

I don't think so. I forget why cheap-module-source-map was chosen for production. Do you think it should be different in production?

adantoscano commented 7 years ago

You can see here https://webpack.js.org/configuration/devtool/ the tab that cheap is for a fast rebuild but not for production and the oposite with source-map.

image

jedireza commented 7 years ago

Want to open a PR with the fix you're suggesting?

jedireza commented 6 years ago

I've decided to archive this project. Thank you for your interest and contributions. https://github.com/jedireza/aqua#no-longer-maintained