Update user.name reference in Account and Admin collection

jedireza / aqua

:bulb: A website and user system starter

https://jedireza.github.io/aqua/

MIT License

1.38k stars 356 forks source link

Update user.name reference in Account and Admin collection #264

Closed ivanph closed 6 years ago

ivanph commented 6 years ago

When the username changes in the Users collection the reference in Account and Admin should also be updated.

Closes #258

I'm not sure if this is the best approach, let me know if you would like a different implementation. I thought about checking if the username really changed before calling update on Admin and Account but I wasn't sure how to go about it.

jedireza commented 6 years ago

I just remembered that folks can change their own usernames. We should probably update this handler too: https://github.com/jedireza/aqua/blob/6d30d0ae63165f03f60adbdfca6009ef2f39fe25/server/api/users.js#L304

ivanph commented 6 years ago

Pushed a new commit with the changes to the /users/my endpoint. I'll squash everything at the end.

jedireza commented 6 years ago

💥 Very cool! Thanks for taking this on. If you're up for it we can apply the same patch to Frame.

ivanph commented 6 years ago

Sure, I'll reopen jedireza/frame#184 if that's okay.