Closed abritinthebay closed 9 years ago
Thanks for opening a PR. This seems reasonable. We should get the tests passing again though.
Ah, agreed. Looks like you have it failing at less that 100% coverage? That's... impressive :)
Will update tests. Not too familiar with Lab but it looks pretty standard.
Ok, updated the tests and I moved the jsxCompile
check into the runtime so it's a) easier to test and b) more flexible.
That said - because of the way node-jsx works once it's loaded... it's loaded. That's why the tests are in that order as well. It needs to test those first otherwise it can't test a failure state.
Let me know if there are any more changes you'd like to see.
Will do. Apologies for the delay, I got slammed after we last chatted.
No worries - been there... repeatedly.
I sent a minor PR to your fork. If you merge that, the changes will show up here.
Ok cool. Let's squash the commits into one and I'll merge.
Done and done :)
Hmm. Not sure about that 3.0.1
commit that got in here.
I think that's just because of your PR. It does list you as the author of it so... no idea.
Looks like the result of an npm patch that isn't in master maybe?
Maybe you re-based one commit too many? The 3.0.1
is the latest commit on master (1ed5b14f).
I just rebased. As it's my fork it shouldn't affect yours, and will just merge.
Great. Thank you! This looks good. I'm in a meeting right now, but I'll do a final review later to double check and merge.
Adds ability to turn off jsx compilation if not required - for example if using babel's require hook or writing in ES5 style React.
This is especially useful as node-jsx is super slow and it eliminates the need for this when it's not required.