Closed tkh44 closed 8 years ago
Thanks for creating a PR! I'd like to hold off on releasing this until 0.14
is out of rc
status.
I'm not sure how to handle legacy support. Any ideas?
Since upgrading to 0.14
will be a breaking change we'll bump our major anyways, so people could always use the older versions.
Sounds good. When 14 is released I'll update the package.json.
Closing this PR for now.
And right after I close this, I see the tweets and blog post about React 0.14
proper :smile: haha. Feel free to update this PR.
Can this be landed? And also an npm publish? Thanks!
As part of React 0.14 support, is there a plan to also switch from node-jsx to babel?
@tkh44 I submitted a minor patch to your fork.
@bbondy yes. We're just about there.
@ark4innovation I would like to use babel instead. Would you be willing to create a PR for that?
@jedireza I merged it.
@tkh44 ok great! Let's squash the commits into one that reads Add support for react 14
(your original commit message).
If you need help with squashing commits see:
:pager: We should get this change landed soon.
@jedireza Should be good now.
:shipit: Thanks!
Use ReactDOMServer to render server side markup.
I'm not sure how to handle legacy support. Any ideas?