jedireza / hapi-react-views

:package: A hapi view engine for React components
MIT License
231 stars 33 forks source link

Add support for react 14 #28

Closed tkh44 closed 8 years ago

tkh44 commented 8 years ago

Use ReactDOMServer to render server side markup.

I'm not sure how to handle legacy support. Any ideas?

jedireza commented 8 years ago

Thanks for creating a PR! I'd like to hold off on releasing this until 0.14 is out of rc status.

I'm not sure how to handle legacy support. Any ideas?

Since upgrading to 0.14 will be a breaking change we'll bump our major anyways, so people could always use the older versions.

tkh44 commented 8 years ago

Sounds good. When 14 is released I'll update the package.json.

jedireza commented 8 years ago

Closing this PR for now.

jedireza commented 8 years ago

And right after I close this, I see the tweets and blog post about React 0.14 proper :smile: haha. Feel free to update this PR.

bbondy commented 8 years ago

Can this be landed? And also an npm publish? Thanks!

ark4innovation commented 8 years ago

As part of React 0.14 support, is there a plan to also switch from node-jsx to babel?

jedireza commented 8 years ago

@tkh44 I submitted a minor patch to your fork.

@bbondy yes. We're just about there.

@ark4innovation I would like to use babel instead. Would you be willing to create a PR for that?

tkh44 commented 8 years ago

@jedireza I merged it.

jedireza commented 8 years ago

@tkh44 ok great! Let's squash the commits into one that reads Add support for react 14 (your original commit message).

If you need help with squashing commits see:

jedireza commented 8 years ago

:pager: We should get this change landed soon.

tkh44 commented 8 years ago

@jedireza Should be good now.

jedireza commented 8 years ago

:shipit: Thanks!