Closed tanepiper closed 9 years ago
Adding this link for future reference: http://stackoverflow.com/q/33505992
Thanks for creating a PR! I left a few minor comments inline. We'll need to add tests for this and figure out why TravisCI is failing.
@jedireza Tests are failing because you're testing against Hapi 11, which only supports node >4 now (see build https://travis-ci.org/jedireza/hapi-react-views/builds/89329509)
@jedireza FYI - Happy to help migrate this library through to ES2015 and ensure support for > Hapi 11 and Babel 6
@jedireza Changes reverted as per comments
I left a PR on your fork to update the readme. After you merge that, squash the commits into one and then we can merge. The final commit message could be something like hapi 11 + node 4 + better es6 support
, but it's up to you.
If you need help with squashing see:
This was fun. Thank you.
:shipit: on a :ship:
@jedireza Thank you! Glad I could help make this happen :dancer:
When using ES2015 with Babel6, it appears you need to check for the default export when the react template is transpiled.
This adds a check to see if Component.default exists, if it does then it uses this instead to pass to React.createFactory