jedireza / hapi-react-views

:package: A hapi view engine for React components
MIT License
231 stars 33 forks source link

Layout feature #55

Closed jedireza closed 8 years ago

jedireza commented 8 years ago

Related to #53 📟 @abritinthebay

To finish this up:

abritinthebay commented 8 years ago

oh nice. I like the solution using `dangerouslySetInnerHTML, that's nice and clean. Not sure why I didn't use that originally.

abritinthebay commented 8 years ago

Looks like Vision/Hoek updated and is breaking your tests.

jedireza commented 8 years ago

Besides code coverage failing, locally tests are running are passing. I restarted Travis to see what's up.

jedireza commented 8 years ago

Ok it may have been some caching features added to the Travis config a while ago. I removed those and now we're just failing because of code coverage. 😉

jedireza commented 8 years ago

Once the build passes we should be good to go. @abritinthebay would be willing to give things a final review? Thoughts on the docs?

abritinthebay commented 8 years ago

Docs look good - little sparse but combined with the examples I think it's reasonably clear. Seems solid.