Closed jedireza closed 8 years ago
oh nice. I like the solution using `dangerouslySetInnerHTML, that's nice and clean. Not sure why I didn't use that originally.
Looks like Vision/Hoek updated and is breaking your tests.
Besides code coverage failing, locally tests are running are passing. I restarted Travis to see what's up.
Ok it may have been some caching features added to the Travis config a while ago. I removed those and now we're just failing because of code coverage. 😉
Once the build passes we should be good to go. @abritinthebay would be willing to give things a final review? Thoughts on the docs?
Docs look good - little sparse but combined with the examples I think it's reasonably clear. Seems solid.
Related to #53 📟 @abritinthebay
PLACEHOLDER
constantlayoutKeyword
optiondangerouslySetInnerHTML={{ __html: this.props.children }}
to place the view contentcontext
is passed to both the layout and the view and isn't duplicated/copiedexamples/layout
toexamples/layout-component
examples/layout
andexamples/remount
to use the new layout featureexamples/remount
lab
to fail CI if code coverage is below 100%hoek@4
, dev dependenciesinert@4
To finish this up: