Update for Node MongoDB driver v3+

jedireza / mongo-models

:package: Map JavaScript classes to MongoDB collections

MIT License

67 stars 28 forks source link

Update for Node MongoDB driver v3+ #28

Closed andyfry01 closed 6 years ago

andyfry01 commented 6 years ago

This PR updates the package to accommodate breaking changes introduced in the Node MongoDB driver v3+.

Changes:

Changed the connection API for MongoModels#connect. Previously it took a mongodb URI string as its first argument, and it now accepts a connection object consisting of two properties:
1. a mongodb uri (e.g. mongodb://localhost:27017)
2. the name of the database being connected to (e.g. test_database)
Updated API.md, README.md, and test/index.js to accommodate the API change.

This resolves #27

jedireza commented 6 years ago

Will you be able to resolve the merge conflicts?

jedireza commented 6 years ago

I was able to grok your PR and just pushed an update to #25 to support the mongodb driver v3.x.

jedireza commented 6 years ago

I'm going to close this PR for now. The rest of the work is with documenting the changes. If you have time for a code review of #25 that would be very helpful. Thanks again for getting involved.

andyfry01 commented 6 years ago

As in just do a pull of the async-await branch and do a general code review? I could do that. If you'd like some documentation updates I can do that too

jedireza commented 6 years ago

https://github.com/jedireza/mongo-models/pull/25 is ready for a final review. I've updated the docs.