search

jedisct1 / libsodium

A modern, portable, easy to use crypto library.
https://libsodium.org
Other
12.15k stars 1.73k forks source link

tvOS library export in 'apple-xcframework.sh' #1004

Closed danielrbrowne closed 3 years ago

danielrbrowne commented 3 years ago

I couldn't find anything in the README, but is there a technical reason why there is no tvOS library export in the apple-xcframework.sh script?

I work on a library which is using the related swift-sodium library, and would ideally like to offer tvOS support.

Is there a technical limitation here with the available APIs on tvOS, or is it simply work which is pending?

jedisct1 commented 3 years ago

Hi Daniel!

I don't think there is a technical limitation. At least not any more with the XCFramework (compared to a single fat library as we used to do before).

It just requires the apple-xcframework.sh to be updated with an extra pass having the right compilation flags for tvOS.

danielrbrowne commented 3 years ago

Thanks for the input - I've not got any direct experience with XCFrameworks building, is this something you think is trivial enough for me to open a PR to resolve (and then one for swift-sodium too), or are there any gotchas?

jedisct1 commented 3 years ago

Fixed via #1005