Adds tvOS support for Apple XCFramework generation

jedisct1 / libsodium

A modern, portable, easy to use crypto library.

https://libsodium.org

Other

12.15k stars 1.73k forks source link

Adds tvOS support for Apple XCFramework generation #1005

Closed danielrbrowne closed 3 years ago

danielrbrowne commented 3 years ago

This PR resolves #1004

Adds tvOS support to the dist-build/apple-xcframework.sh script.

danielrbrowne commented 3 years ago

I'm currently getting the following error in the generated build_log when running the script (from the repo root directory, using Xcode 11.7):

./dist-build/apple-xcframework.sh: line 80: ./configure: No such file or directory

Am I missing something @jedisct1 ?

jedisct1 commented 3 years ago

Thanks!

tvOS simulators for i386 don't exist, so this is not going to work.

The tvOS build script will exit prematurely, and the XCFramework won't include tvOS versions.

I removed the tvos-simulator-i386 target. Build in progress :)

danielrbrowne commented 3 years ago

@jedisct1 Did you push any changes? I don't see them in this PR...

jedisct1 commented 3 years ago

Yep: https://github.com/jedisct1/libsodium/commit/a28ffeef97a3e9c2d015c3004a1e4e06a39900a3

danielrbrowne commented 3 years ago

Ah OK sorry I missed that - assuming this works, I'm not sure what is needed to bring in the updated XCFramework for swift-sodium, but I'd appreciate a new release with it included :)

(I have a related PR opened there: https://github.com/jedisct1/swift-sodium/pull/215)

jedisct1 commented 3 years ago

Merged, and the XCFramework has been updated in swift-sodium.

Thanks for contributing this!