Make sure config.sub and config.guess are executable

jedisct1 / libsodium

A modern, portable, easy to use crypto library.

https://libsodium.org

Other

12.15k stars 1.73k forks source link

Make sure config.sub and config.guess are executable #1024

Closed jonglezb closed 3 years ago

jonglezb commented 3 years ago

This fixes Spack build on ppc64 and aarch64, see https://github.com/spack/spack/pull/21256

jedisct1 commented 3 years ago

Hi,

The fact that they need to be executable is a little bit surprising.

The configure script doesn't call them directly, only via a shell command:

$SHELL "$ac_aux_dir/config.guess"

$SHELL "$ac_aux_dir/config.sub"

If the SHELL environment variable empty somehow? That would be the actual issue.

jonglezb commented 3 years ago

Yes, I expect it would work for a normal build.

However, Spack has an autotools workaround where it tries to manually execute these scripts to check if they work (I have no idea what was the original issue that required this workaround). It's applied to all autotools-based packages, not just libsodium.

By the way, the upstream scripts are executable: https://git.savannah.gnu.org/gitweb/?p=config.git;a=tree