jedisct1 / libsodium

A modern, portable, easy to use crypto library.
https://libsodium.org
Other
12.15k stars 1.73k forks source link

Fixed subset checking bug #1043

Closed wyatt-howe closed 3 years ago

wyatt-howe commented 3 years ago

It seems I am the first to use the generate-emscripten-symbols.sh script to select a subset of the symbols smaller than the entire library. The script does subset checking in the wrong direction, incorrectly asserting that the entire library is a subset. It should be the opposite, as committed. I also updated the big list of symbols and disabled a few functions that are no longer commonly used.

jedisct1 commented 3 years ago

generate-emscripten-symbols.sh generates the list of symbols to export for the current build. It's not designed to select a subset, except for the minimal mode.

Please do not change this, especially since you seem to be producing the symbols out of an antiquated version of the library.