search

jedisct1 / libsodium

A modern, portable, easy to use crypto library.
https://libsodium.org
Other
12.06k stars 1.72k forks source link

[dotnet core] build for linux-musl-arm64 #1174

Closed bfren closed 1 year ago

bfren commented 2 years ago

See #1173

ektrah commented 2 years ago

Nice work 😃

The artifact (libsodium.so) also needs to be added to libsodium.pkgproj so it gets included in the NuGet package.

/cc @SeanMollet @enclave-alistair

bfren commented 2 years ago

Done - I think!

ektrah commented 2 years ago

libsodium.pkgproj looks good to me. While you're at it, you could also increment the version number in the same file.

Now someone needs to go ahead and test if the NuGet package actually works on their musl arm64 machine 😊

SeanMollet commented 2 years ago

@ektrah That can be tested in a docker container. I might have some time later this week to build a proper test script for it.

bfren commented 2 years ago

libsodium.pkgproj looks good to me. While you're at it, you could also increment the version number in the same file.

Happy to bump the version - to 1.0.19.0?

ektrah commented 2 years ago

Happy to bump the version - to 1.0.19.0?

That would be 1.0.18.3 (the third revision of the NuGet package containing pre-compiled binaries of libsodium 1.0.18).

bfren commented 2 years ago

@SeanMollet I'm happy to help with writing test scripts - I presume I need to build the package locally to test it? The CI process doesn't appear to publish it anywhere as far as I can tell.

bfren commented 1 year ago

Is there anything more I can do to help get this finalised and merged?

MichalPetryka commented 1 year ago

Could linux-musl-arm and linux-s390x be handled too?

ektrah commented 1 year ago

@MichalPetryka, .NET doesn’t run on s390x. (Note that this particular PR is about the packaging of libsodium for .NET, not libsodium in general.)

MichalPetryka commented 1 year ago

@MichalPetryka, .NET doesn’t run on s390x. (Note that this particular PR is about the packaging of libsodium for .NET, not libsodium in general.)

It does with community builds, fedora package repository does provide s390x builds of it.

bfren commented 1 year ago

I'd be happy to do what I did for arm64 to add an arm build - would the maintainers prefer another PR for that? The issue now is testing though, which I'm happy to help with if I can, and if someone wants to give me a steer.