search

jedisct1 / libsodium

A modern, portable, easy to use crypto library.
https://libsodium.org
Other
12.06k stars 1.72k forks source link

MacCatalyst support #1238

Closed MartyIX closed 1 year ago

MartyIX commented 1 year ago

https://github.com/jedisct1/libsodium/discussions/1235

jedisct1 commented 1 year ago

It doesn't really make sense to build the xcframework only to use one of the files it generates.

We should compile the xcframework once, and use its content for all the Apple targets. And still test them if possible.

MartyIX commented 1 year ago

It doesn't really make sense to build the xcframework only to use one of the files it generates.

Are you aware that it would mean to switch from the .dylib to a .a library? But if you wish so, then ok.

MartyIX commented 1 year ago

I'm not sure how to test the changes in .github/workflows/dotnet-core.yml. Can anyone help a bit?

MartyIX commented 1 year ago

@ektrah Would you possibly know an answer to https://github.com/jedisct1/libsodium/pull/1238#issuecomment-1364203000?

ektrah commented 1 year ago

@MartyIX Thanks a lot for your pull request and apologies for not responding earlier; things are always going a bit slow after the Christmas break 😌

I think the best way to test this would be including your test application in this repository. For that, it would be great if you could provide the steps needed to create the test application from scratch in the command line, e.g.:

$ dotnet new ...
$ dotnet add package libsodium --source path/to/downloaded/github/actions/artifact
... add/modify files ...
$ dotnet build
$ dotnet run
MartyIX commented 1 year ago

@ektrah ee0fe028ecd164084e73f4c87dec6a0cfba89f1a was merged, if it is released, then libsodium-core will need https://github.com/jedisct1/libsodium/discussions/1235#discussioncomment-4397830 change. I think.