search

jedisct1 / libsodium

A modern, portable, easy to use crypto library.
https://libsodium.org
Other
12.06k stars 1.72k forks source link

aarch64 build fails after updating from 1.0.18 to 1.0.19 #1313

Closed Alexander-Wilms closed 9 months ago

Alexander-Wilms commented 9 months ago

The Octave Flatpak package uses libsodium and version 1.0.18 was built successfully:

Cf. CI of latest commit to https://github.com/flathub/org.octave.Octave

But after updating libsodium, the build failed:

https://github.com/flathub/org.octave.Octave/pull/307/files

crypto_aead/aegis128l/aegis128l_armcrypto.c:23:9: error: pragma or attribute ‘target("neon")’ is not valid
   23 | #pragma GCC target("neon,crypto,aes")
      |         ^~~

crypto_aead/aegis256/aegis256_armcrypto.c:23:9: error: pragma or attribute ‘target("neon")’ is not valid
   23 | #pragma GCC target("neon,crypto,aes")
      |         ^~~

See https://buildbot.flathub.org/#/builders/6/builds/65343 for a complete log, which I've attached as well: stdio.txt

cschug commented 9 months ago

Had the same issue on aarch64 and can confirm that fb4533b fixes the issue, thanks a lot!

jedisct1 commented 9 months ago

Thank you!

The tag has been updated to the current stable, that includes that fix, thanks!