search

jedisct1 / libsodium

A modern, portable, easy to use crypto library.
https://libsodium.org
Other
12.06k stars 1.72k forks source link

Shouldn't crypto_pwdhash_PRIMITIVE be 'argon2id' ? #1331

Closed zedalaye closed 7 months ago

zedalaye commented 7 months ago

Hi,

As almost all constants in this file references those of crypto_pwhash_argon2id.h, shouldn't crypto_pwdhash_PRIMITIVE be, in fact "argon2id" ?

https://github.com/jedisct1/libsodium/blob/6ee5a7345296a0a104fc3630bcea56e2f9f0f513/src/libsodium/include/sodium/crypto_pwhash.h#L138C14-L138C14

jedisct1 commented 7 months ago

Good catch!

We should list both, as they are both supported by the high-level APIs.

Thanks!