search

jedisct1 / libsodium

A modern, portable, easy to use crypto library.
https://libsodium.org
Other
12.06k stars 1.72k forks source link

Zig build for windows platform issue #1371

Closed meiyese closed 1 month ago

meiyese commented 1 month ago

Hi, I use zig build for windows, and found that the dll with cause crash.

but msvc build is ok. It may caused by HAVE_AMD64_ASM macro.

HAVE_AMD64_ASM is on by default for zig build, which is off for msvc.

jedisct1 commented 1 month ago

Good catch, thank you!

Yes, absolutely, the calling conventions are different on Windows.

This should be fixed now. Thanks again!