search

jedisct1 / libsodium

A modern, portable, easy to use crypto library.
https://libsodium.org
Other
12.22k stars 1.74k forks source link

Only high-level API now available in prebuilt MinGW binaries #327

Closed Fraser999 closed 8 years ago

Fraser999 commented 8 years ago

It would appear that https://github.com/jedisct1/libsodium/commit/cc29da17c39b0cd881de4fe5d154841057f75f91 changed the distribution builds for MinGW to use the new --enable-minimal option.

This has resulted in reduced functionality between versions 1.0.6 and 1.0.7 of the prebuilt MinGW binaries.

I'm not sure if this is an intended effect, or if so, why that would be wanted. If this is intended, perhaps two sets of prebuilt MinGW targets could be provided; minimal and full?

For reference, I hit this issue when building the tests in the Rust binding (sodiumoxide) of libsodium.

jedisct1 commented 8 years ago

The mingw build scripts were the only ones left that were not using --enable-minimal to skip undocumented and untested functions.

But indeed, some apps and bindings might still be using them, and previous pre-build binaries for MingGW still had these functions around, so it makes sense to keep them in these binaries, until they are completely removed.

The --enable-minimal addition was reverted and new binaries for MinGW have replaced the previous ones.

Fraser999 commented 8 years ago

That's great - thanks very much.