search

jedisct1 / minisign

A dead simple tool to sign files and verify digital signatures.
https://jedisct1.github.io/minisign/
Other
2.05k stars 117 forks source link

#75 is still open technically #99

Closed artemislena closed 1 year ago

artemislena commented 3 years ago

https://github.com/jedisct1/minisign/issues/75 ‒ I actually have (or at least had; it forced me to change my key once) the same issue… OP in there, after closing the issue, asked if he should submit a PR, however, no response came (presumably because there are no notifications on comments on closed issues?)… So this issue's just a reminder, and a possible continuation of the original one, I guess…

artemislena commented 3 years ago

I suppose it would be a good idea to ping @johnalanwoods on this.

infa-jowoods commented 3 years ago

Hey @FantasyCookie17 - yep I got it working, it's a really ugly implementation but it works and cleanly resaves the private key with a new password, and from there you just go back to using the regular client. LMK if you want it

artemislena commented 3 years ago

Well… I'd love to have it implemented in Minisign, however, I'd rather be able to have the benefits from being able to install it from my package manager and such, meaning I'd rather not use custom patches… So what would be great is if you could make the code quality good enough to have it merged in mainline Minisign. Perhaps just open a PR and we'll see? If it actually isn't good enough, perhaps someone else (e.g. @jedisct1 or even me, given I do know a bit of C) might be able to polish it.

maflcko commented 1 year ago

I think this can be closed after commit 16624abf2e73c0bea9290459145f25c7bcec355a ? :)