search

jedisct1 / rust-minisign

A pure Rust implementation of the Minisign signature tool.
Other
92 stars 15 forks source link

specify getrandom "std" feature #2

Closed awortman-fastly closed 5 years ago

awortman-fastly commented 5 years ago

getrandom has a semver-breaking change in 0.1.10, where the std::error::Error impl for getrandom::Error disappeared for linux, macos, and other OSes disappeared unless the std feature was specified. specifying std as a feature is backwards-compatible with old getrandom versions, and arguably std::error::Error being present for any target OS regardless of std being present was an error in the first place.

jedisct1 commented 5 years ago

Thanks Andy!

Breaking changes in minor version bumps are not great :(

Anyway, we don't really need the Error trait. Since the private trait implements Display, that should be enough.

Version 0.5.12 with that change is now on crates.io.

Thanks!